Skip to content

(I001) check om version for the model executable#446

Open
syntron wants to merge 12 commits into
OpenModelica:masterfrom
syntron:I001-check_om_version_model_executable
Open

(I001) check om version for the model executable#446
syntron wants to merge 12 commits into
OpenModelica:masterfrom
syntron:I001-check_om_version_model_executable

Conversation

@syntron

@syntron syntron commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

due to changes in OMC, there are 2 different ways to define simulation parameters (pre and post 1.26.0). Currently, the version string needs to be correctly defined for the runner class. This PR adds a check of the xml file to extract the version string from there.

see discussion in PR #401

@syntron syntron force-pushed the I001-check_om_version_model_executable branch from e4cf36f to 6d8ecd9 Compare March 9, 2026 19:46
@syntron syntron force-pushed the I001-check_om_version_model_executable branch from 6d8ecd9 to efd6775 Compare May 11, 2026 18:53
@syntron syntron force-pushed the I001-check_om_version_model_executable branch 3 times, most recently from 48d1110 to 2107aff Compare June 27, 2026 18:35
syntron added 12 commits June 30, 2026 21:42
[README.md] small updates

[__init__] small updates
* ModelExecutionData => ModelExecutionRun
* ModelExecutionCmd => ModelExecutionConfig
[pylint] fix 'R1729: Use a generator instead 'all(isinstance(item, tuple) for item in val_evaluated)' (use-a-generator)'

[pylint] fix 'W0237: Parameter 'expr' has been renamed to 'command' in overriding 'OMCSessionZMQ.sendExpression' method (arguments-renamed)'

[pylint] [OM*Path*] fix pylint messags about incompatible definitions
[ModelExecutionException] catch exception if ModelExecutionCmd.run() is used

[bugfix] [ModelicaSystem] fix exception; use ModelicaSystemError (instead of wrong ModelExecutionException)

[bugfix] [ModelicaSystemABC] fix _prepare_input_data() - ensure returned data is dict[str, str]
[compatibility] add class wrapper to provide the depreciation message

[ModelicaSystem] fix / improve wrapper functions for v4.0.0 compatibility

[ModelicaSystemABC] additional checks for setInputs()

[test_ModelicaSystemOMC] add tests for setInputs()

[__init__] define ModelicaSystemDoE at the right point (=> compatibility layer)

[__init__] remove duplicate 'OMCSessionABC' in __all__
[ModelicaSystemABC] remove code for (depreciated) arguments in set*() methods

* define code in the compatibility layer in class ModelicaSystem

[test_ModelicaSystem(OMC)] update tests

* for new version: remove usage of old definition
* for compatibility version: test old definition
[OMCSessionABC] remove execute(); still available in compatibility v4.0.0

[ModelicaSystem] define _set_compatibility_helper() as static

[ModelExecutionCmd] remove depreciated simflags

[test_ModelSystemCmd/ModelExecutionCmd] fix test due to changes

[ModelicaSystemCmd] cleanup - do not define (unused / not useable) class
@syntron syntron force-pushed the I001-check_om_version_model_executable branch from 2107aff to 6d67447 Compare June 30, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant